Modify registerPrompt to accept undefined Args type#1516
Open
andershagbard wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
Modify registerPrompt to accept undefined Args type#1516andershagbard wants to merge 2 commits intomodelcontextprotocol:mainfrom
andershagbard wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 95ef3c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When using
registerPromptwithout anyargsSchemathe callback will still be typed as the first argument is the input of the argsSchema, which is not the case.This PR corrects that.
Code:
Current type:
Correct type:
How Has This Been Tested?
Tested in a project using
mcp-handlerBreaking Changes
Maybe someone has used the types incorrectly. Unsure if this counts as breaking, as it's a bugfix.
Types of changes
Checklist